Skip to content

Fix renovate CI #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2025
Merged

Fix renovate CI #35

merged 7 commits into from
Mar 7, 2025

Conversation

@vbontempi
Copy link
Member

@vbontempi vbontempi commented Feb 24, 2025 •
edited
Loading

Description

Fix for renovate CI PR

Package Type Update Change
github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper require minor v1.45.2 -> v1.46.2
go (source) toolchain minor 1.23.6 -> 1.24.0
k8s.io/apimachinery require minor v0.28.4 -> v0.32.2

Block terraform provider version for all-combined example to 1.75.2 to go around provider issue IBM-Cloud/terraform-provider-ibm#6050

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vbontempi
Copy link
Member Author

vbontempi commented Feb 24, 2025

/run pipeline

@vbontempi vbontempi requested review from ocofaigh and removed request for daniel-butler-irl February 24, 2025 15:36
@ocofaigh
Copy link
Contributor

ocofaigh commented Feb 24, 2025

@vbontempi This is the package I mentioned we have an issue with in this repo:
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package spdy: could not load export data: no export data for \"k8s.io/client-go/transport/spdy\""

We need to figure out why it fails on latest version

@vbontempi
Copy link
Member Author

vbontempi commented Feb 25, 2025

@vbontempi This is the package I mentioned we have an issue with in this repo: level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package spdy: could not load export data: no export data for \"k8s.io/client-go/transport/spdy\""

We need to figure out why it fails on latest version

Forcing update of common-dev-assets alone solves the issue #36
Rebasing the PR due to the last merge of yesterday and running tests again

@vbontempi
Copy link
Member Author

vbontempi commented Feb 25, 2025

running #36 in advance and rebasing this to solve the issues

@vbontempi
Copy link
Member Author

vbontempi commented Mar 3, 2025

/run pipeline

@vbontempi
Copy link
Member Author

vbontempi commented Mar 3, 2025

@vbontempi This is the package I mentioned we have an issue with in this repo: level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package spdy: could not load export data: no export data for \"k8s.io/client-go/transport/spdy\""
We need to figure out why it fails on latest version

Forcing update of common-dev-assets alone solves the issue #36 Rebasing the PR due to the last merge of yesterday and running tests again

this didn't help, we need to dig into this

@vbontempi
Copy link
Member Author

vbontempi commented Mar 5, 2025

/run pipeline

@vbontempi
Copy link
Member Author

vbontempi commented Mar 5, 2025

/run pipeline

@vbontempi
Copy link
Member Author

vbontempi commented Mar 6, 2025

/run pipeline

@toddgiguere toddgiguere merged commit 5dc050e into main Mar 7, 2025
2 checks passed
@toddgiguere toddgiguere deleted the fix_renovate_ci branch March 7, 2025 13:17
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Mar 15, 2025

🎉 This PR is included in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toddgiguere toddgiguere toddgiguere approved these changes

@ocofaigh ocofaigh Awaiting requested review from ocofaigh

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vbontempi @ocofaigh @terraform-ibm-modules-ops @toddgiguere